Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fail_n_times field to add ability to configure a request to fail x number of times before receiving a valid response #1472

Open
parthea opened this issue Mar 20, 2024 · 2 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@parthea
Copy link
Contributor

parthea commented Mar 20, 2024

Proposal:
Add a Showcase.Echo RPC with a int fail_n_times field that initially fails n number of times before returning a valid response.

This will allow us to test the following requirement from AIP-4235 without the use of interceptors:

  • Client libraries must reuse automatically populated values for retries of the same request.
@parthea parthea added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 20, 2024
@vchudnov-g
Copy link
Contributor

This sounds straightforward to implement.

@noahdietz
Copy link
Collaborator

Does it make sense/seem possible to implement as part of the Sequence service? It is designed to test retry behavior so it already supports this requirement. The missing part would be ensuring/echoing back the request_id to enable the generator to assert on its generated client's behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants