Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable TypeScript smoke tests after Docker image includes diregapic changes #827

Open
vchudnov-g opened this issue Aug 5, 2021 · 2 comments
Open

Re-enable TypeScript smoke tests after Docker image includes diregapic changes #827

vchudnov-g opened this issue Aug 5, 2021 · 2 comments
Assignees
@vchudnov-g
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. process process/chore oriented work

Comments

@vchudnov-g
Copy link
Contributor

vchudnov-g commented Aug 5, 2021 •
edited

The current Docker image for TypeScript was last generated in 2020-09 and excludes the DIREGAPIC changes. In particular, the Docker image thus lacks support for mapped pagination responses, causing smoke tests in #816 to fail.

We are temporarily disabling those smoke tests, but they should be re-enabled as soon as the TS Docker image is updated.
@vchudnov-g vchudnov-g added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. process process/chore oriented work labels Aug 5, 2021
@vchudnov-g vchudnov-g self-assigned this Aug 6, 2021
@vchudnov-g
Copy link
Contributor Author

@summer-ji-eng Could you ping this bug when the Docker image has been updated? Thanks!

@vchudnov-g vchudnov-g mentioned this issue Aug 10, 2021
Closed
@alexander-fenster
Copy link
Contributor

Being resolved in googleapis/gapic-generator-typescript#1012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vchudnov-g vchudnov-g

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. process process/chore oriented work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexander-fenster @vchudnov-g