feat(v2): copy DetermineContentType functionality #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartzmo
reviewed
Oct 5, 2022
quartzmo
approved these changes
Oct 6, 2022
tritone
approved these changes
Oct 10, 2022
|
Still want @codyoss's eyes stamp as this adds new APIs. |
codyoss
reviewed
Oct 10, 2022
|
@noahdietz A couple of small comments, lmk wyt. |
codyoss
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies the implementation of an internal utility from
google.golang.org/api/internal/gensupport,DetermineContentType, as well as the supporting internal types for content sniffing.Once this is released, the corresponding usage of this API in
gensupportwill be replaced withgax's version so that we have one place for bug fixes.