Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Is RefreshingManagedChannel being used, or just an experiment? #1084

Closed
ejona86 opened this issue May 29, 2020 · 2 comments
Closed

Is RefreshingManagedChannel being used, or just an experiment? #1084

ejona86 opened this issue May 29, 2020 · 2 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@ejona86
Copy link

ejona86 commented May 29, 2020

I happened on RefreshingManagedChannel added in #805, and it concerned me because re-creating the channel is heavy-weight and this may prevent future work. I'm most concerned that to my knowledge grpc team wasn't notified, since this can bite us.

Is this being used by someone, or just an experiment?

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label May 30, 2020
@miraleung miraleung self-assigned this Jun 1, 2020
@miraleung miraleung added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Jun 1, 2020
@miraleung
Copy link
Contributor

Looks like it is, see #804. Please reach out to the original reporters / authors if further discussion is needed.

@ejona86
Copy link
Author

ejona86 commented Jun 2, 2020

@miraleung, did you paste the wrong issue/PR? I saw the issue posted and saw the PR #805. But that just exposes an API. It is enabled if you provide a ChannelPrimer, which is @InternalApi("For internal use by google-cloud-java clients only"). The question is if there is a user of it.

Based on a search of GitHub, it appears it is only used by CBT, but since the implementation is using the grpc-experimental API it requires explicit opt-in via a BetaApi.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

No branches or pull requests

3 participants