This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
feat: add api key support #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
arithmetic1728
force-pushed
the
apikey
branch
3 times, most recently
from
21e5af6
to
8c840ba
Compare
arithmetic1728
added
the
do not merge
TimurSadykov
approved these changes
Sep 15, 2021
gax/src/test/java/com/google/api/gax/rpc/ClientContextTest.java
Outdated
Show resolved
Hide resolved
arithmetic1728
force-pushed
the
apikey
branch
from
aaf7fe8
to
808e10f
Compare
arithmetic1728
force-pushed
the
apikey
branch
from
808e10f
to
af88ce0
Compare
chanseokoh
reviewed
Jan 20, 2022
gax/src/test/java/com/google/api/gax/rpc/ClientContextTest.java
Outdated
Show resolved
Hide resolved
gax/src/test/java/com/google/api/gax/rpc/ClientContextTest.java
Outdated
Show resolved
Hide resolved
gax/src/test/java/com/google/api/gax/rpc/ClientContextTest.java
Outdated
Show resolved
Hide resolved
chanseokoh
reviewed
Jan 20, 2022
gax/src/test/java/com/google/api/gax/rpc/ClientContextTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Chanseok Oh <chanseok@google.com>
Co-authored-by: Chanseok Oh <chanseok@google.com>
chanseokoh
reviewed
Jan 20, 2022
gax/src/test/java/com/google/api/gax/rpc/ClientContextTest.java
Outdated
Show resolved
Hide resolved
gax/src/test/java/com/google/api/gax/rpc/ClientContextTest.java
Outdated
Show resolved
Hide resolved
gax/src/test/java/com/google/api/gax/rpc/ClientContextTest.java
Outdated
Show resolved
Hide resolved
gax/src/test/java/com/google/api/gax/rpc/ClientContextTest.java
Outdated
Show resolved
Hide resolved
Will remove the "Do Not Merge" after a manual test with samples. |
chanseokoh
approved these changes
Jan 20, 2022
gax/src/test/java/com/google/api/gax/rpc/ClientContextTest.java
Outdated
Show resolved
Hide resolved
gax/src/test/java/com/google/api/gax/rpc/ClientContextTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Chanseok Oh <chanseok@google.com>
Co-authored-by: Chanseok Oh <chanseok@google.com>
arithmetic1728
removed
the
do not merge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 21, 2022
🤖 I have created a release *beep* *boop* --- ## [2.10.0](v2.9.0...v2.10.0) (2022-01-21) ### Features * add api key support ([#1436](#1436)) ([5081ec6](5081ec6)) * introduce HttpJsonClientCall, Listeners infrastructure and ServerStreaming support in REST transport ([#1599](#1599)) ([3c97529](3c97529)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
arithmetic1728
added a commit
that referenced
this pull request
Jan 28, 2022
arithmetic1728
added a commit
that referenced
this pull request
Jan 29, 2022
suztomo
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Dec 16, 2022
🤖 I have created a release *beep* *boop* --- ## [2.10.0](googleapis/gax-java@v2.9.0...v2.10.0) (2022-01-21) ### Features * add api key support ([#1436](googleapis/gax-java#1436)) ([e85699a](googleapis/gax-java@e85699a)) * introduce HttpJsonClientCall, Listeners infrastructure and ServerStreaming support in REST transport ([#1599](googleapis/gax-java#1599)) ([7003903](googleapis/gax-java@7003903)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds API key support. Internal doc: go/gapic-api-key-support
The new logic is:
(1) if API key is provided via
StubSettings.apiKey, use the API key, we are done(2) if both
GOOGLE_API_KEYandGOOGLE_APPLICATION_CREDENTIALSenv variables are set, throw exception; ifGOOGLE_API_KEYis provided, use the API key; otherwise, use the normal ADC flow.This PR has been tested with java-language. arithmetic1728/java-language#1