Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Clean up testlib artifact #700

Closed
elharo opened this issue Apr 4, 2019 · 0 comments · Fixed by #1120
Closed

Clean up testlib artifact #700

elharo opened this issue Apr 4, 2019 · 0 comments · Fixed by #1120
Assignees
@miraleung
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: cleanup An internal cleanup or hygiene concern.

Comments

@elharo
Copy link
Contributor

elharo commented Apr 4, 2019

The testlib jar published on maven central in https://repo1.maven.org/maven2/com/google/api/gax/ appears to contain both unit tests and test infrastructure. These should be split. The unit tests should not be published to maven central. Supported test infrastructure that is intended for use by external clients should be published. However it should be separated from GAX's own tests in the source repo.

Furthermore the build system does not appear to provide sources for the testlib jar.
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 5, 2019
@vam-google vam-google added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels Apr 8, 2019
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Apr 8, 2019
@sduskis sduskis removed the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jun 12, 2019
@miraleung miraleung self-assigned this Jun 4, 2020
@miraleung miraleung linked a pull request Jun 5, 2020 that will close this issue
[gax-java] chore: include only external-facing gax testing utils in testlibJar #1120
Merged
@miraleung miraleung mentioned this issue Jun 5, 2020
Merged
@miraleung miraleung added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 5, 2020
@suztomo suztomo mentioned this issue Oct 5, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miraleung miraleung

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[gax-java] chore: include only external-facing gax testing utils in testlibJar googleapis/gax-java
5 participants
@sduskis @elharo @miraleung @vam-google @yoshi-automation