Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

chore(deps): Add javax.annotations dependency in bazel build to gax-grpc #1000

Merged
merged 3 commits into from Mar 31, 2020

Conversation

vam-google
Copy link
Contributor

This is to solve java11 incompatibility issue.
Also use transitive dependencies directly from grpc for bazel.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2020
@yihanzhen
Copy link
Contributor

LGTM

@yihanzhen yihanzhen changed the title chore(deps): Add javax.annotations dependency in bazel build to gax-grp chore(deps): Add javax.annotations dependency in bazel build to gax-grpc Mar 31, 2020
@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #1000 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1000   +/-   ##
=========================================
  Coverage     78.66%   78.66%           
  Complexity     1167     1167           
=========================================
  Files           204      204           
  Lines          5152     5152           
  Branches        413      413           
=========================================
  Hits           4053     4053           
  Misses          925      925           
  Partials        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad62e61...a8804dd. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants