Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

chore: display call settings configuration through toString #1017

Merged
merged 2 commits into from Apr 15, 2020

Conversation

rahulKQL
Copy link
Contributor

@rahulKQL rahulKQL commented Apr 8, 2020

This enables displaying UnaryCallSettings, ServerStreamingCallSettings & BatchingCallSettings configuration values through toString().

Did not include BatchingDescriptor, FlowController and StreamResumptionStrategy from these callSetting's toString() as these does not contain any settings.

Towards Bigtable#233
This would enable us to display client-specific default settings

This enables displaying UnaryCallSettings, ServerStreamingCallSettings & BatchingCallSettings configuration values through toString().
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 8, 2020
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #1017 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1017      +/-   ##
============================================
+ Coverage     78.67%   78.75%   +0.07%     
- Complexity     1167     1171       +4     
============================================
  Files           204      204              
  Lines          5154     5173      +19     
  Branches        413      413              
============================================
+ Hits           4055     4074      +19     
  Misses          925      925              
  Partials        174      174              
Impacted Files Coverage Δ Complexity Δ
.../google/api/gax/batching/BatchingCallSettings.java 96.87% <100.00%> (+0.57%) 6.00 <1.00> (+1.00)
...a/com/google/api/gax/rpc/BatchingCallSettings.java 95.00% <100.00%> (+0.71%) 8.00 <1.00> (+1.00)
...oogle/api/gax/rpc/ServerStreamingCallSettings.java 70.49% <100.00%> (+2.63%) 7.00 <1.00> (+1.00)
...java/com/google/api/gax/rpc/UnaryCallSettings.java 100.00% <100.00%> (ø) 6.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8827ad...e05204d. Read the comment docs.

@rahulKQL rahulKQL requested a review from elharo April 10, 2020 06:55
@rahulKQL rahulKQL added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2020
@rahulKQL rahulKQL merged commit c62bb8a into googleapis:master Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants