Linkage Checker to examine linkage error at artifact level #1032
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1032 +/- ##
=========================================
Coverage 78.76% 78.76%
Complexity 1171 1171
=========================================
Files 204 204
Lines 5180 5180
Branches 416 416
=========================================
Hits 4080 4080
Misses 925 925
Partials 175 175 Continue to review full report at Codecov.
|
As part of linkage-monitor.sh script, new linkage checker tasks worked for each artifact:
|
@elharo @chingor13 PTAL. |
@@ -0,0 +1,2 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't we simply not have such a file here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would work. However the build.gradle would have if-statement to check whether the project is gax-grpc or not, to set the argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed these empty files in favor of the if-statement in build.gradle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elharo PTAL.
@@ -0,0 +1,2 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed these empty files in favor of the if-statement in build.gradle.
if (project.name == 'gax-grpc') { | ||
// The exclusion file can be regenerated by '-o' option. See its Wiki for details: | ||
// https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/LinkageCheckerMain#exclusion-files | ||
arguments += ['--exclusion-file', 'linkage-checker-exclusion.xml'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me wonder if we really need to set the name and have a command line argument at all. Does it make sense to have a standard filename and location where the linkage checker looks?
|
Java 7 from Kokoro
Somehow there was one successful Java 7 Kokoro build 73eadc5: https://source.cloud.google.com/results/invocations/bbaaac7f-a8dd-4310-8bb7-0ea02c74be11/targets/cloud-devrel%2Fclient-libraries%2Fjava%2Fgax-java%2Fpresubmit%2Fjava7/log |
@chingor13 @stephaniewang526 Would you update repository setting for "Required" check? I stopped Kokoro's checks for gax-java.
|
Updated the settings manually and will manage this repo's settings via our settings bot: googleapis/repo-automation-bots#565 |
Linkage Checker to examine linkage error at artifact level