Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

deps: update grpc to 1.30.0, protobuf to 3.12.2 #1125

Merged
merged 3 commits into from Jun 10, 2020
Merged

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jun 9, 2020

@chingor13 chingor13 requested review from elharo and a team June 9, 2020 20:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 9, 2020
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #1125 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1125   +/-   ##
=========================================
  Coverage     78.66%   78.66%           
  Complexity     1169     1169           
=========================================
  Files           204      204           
  Lines          5189     5189           
  Branches        417      417           
=========================================
  Hits           4082     4082           
  Misses          933      933           
  Partials        174      174           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecbab4a...daaa4a7. Read the comment docs.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think protobuf 3.12.2 is out

@chingor13
Copy link
Contributor Author

I was trying to match what's in libraries-bom. Perhaps we should bump to 1.30.0 and 3.12.2 respectively both here and in libraries-bom?

@chingor13 chingor13 changed the title deps: update grpc to 1.29.0, protobuf to 3.12.1 deps: update grpc to 1.30.0, protobuf to 3.12.2 Jun 9, 2020
@suztomo
Copy link
Member

suztomo commented Jun 9, 2020

Class com.ning.compress.lzf.LZFChunk is not found;
  referenced by 1 class file
    io.grpc.netty.shaded.io.netty.handler.codec.compression.LzfEncoder (io.grpc:grpc-netty-shaded:1.30.0)

io.grpc:grpc-netty-shaded:1.30.0 is at:
  com.google.api:gax-grpc:jar:1.56.0 / io.grpc:grpc-netty-shaded:1.30.0 (compile)
  and 1 dependency path.


> Task :gax-grpc:checkJavaLinkage FAILED

Checking whether this is in the exclusion file.

@suztomo
Copy link
Member

suztomo commented Jun 9, 2020

The target & source pair is not listed. It's a new linkage error in the dependency.

Would you add the following element to https://github.com/googleapis/gax-java/blob/chingor13-patch-1/gax-grpc/linkage-checker-exclusion.xml#L171 ?

  <LinkageError>
    <Target>
      <Class name="com.ning.compress.lzf.LZFChunk"/>
    </Target>
    <Source>
      <Class name="io.grpc.netty.shaded.io.netty.handler.codec.compression.LzfEncoder"/>
    </Source>
  </LinkageError>

@elharo
Copy link
Contributor

elharo commented Jun 10, 2020

Can we fix this instead of excluding it? This is a true positive. Do we care?

@suztomo
Copy link
Member

suztomo commented Jun 10, 2020

@elharo I don't think we can fix it. It is true positive while gRPC users do not suffer from this. The reference is from shaded Netty for the (unused) compression algorithm.

@suztomo
Copy link
Member

suztomo commented Jun 10, 2020

9 successful checks

Thank you.

@chingor13 chingor13 merged commit aed805e into master Jun 10, 2020
@chingor13 chingor13 deleted the chingor13-patch-1 branch June 10, 2020 21:57
@reachlakstar
Copy link

reachlakstar commented Aug 3, 2020

I am using Apache beam with grpc and dataflow. 1.29.0 and 3.12.2, facing same issue. any solution for this.
java.lang.ClassNotFoundException: io.grpc.internal.BaseDnsNameResolverProvider

@suztomo
Copy link
Member

suztomo commented Aug 3, 2020

@reachlakstar The class does not seem gax-java. Would you create an issue in Beam's issue management with your pom.xml or build.gradle, and give me the URL?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants