deps: update grpc to 1.30.0, protobuf to 3.12.2 #1125
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1125 +/- ##
=========================================
Coverage 78.66% 78.66%
Complexity 1169 1169
=========================================
Files 204 204
Lines 5189 5189
Branches 417 417
=========================================
Hits 4082 4082
Misses 933 933
Partials 174 174 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think protobuf 3.12.2 is out
I was trying to match what's in libraries-bom. Perhaps we should bump to 1.30.0 and 3.12.2 respectively both here and in libraries-bom? |
Checking whether this is in the exclusion file. |
The target & source pair is not listed. It's a new linkage error in the dependency. Would you add the following element to https://github.com/googleapis/gax-java/blob/chingor13-patch-1/gax-grpc/linkage-checker-exclusion.xml#L171 ?
|
Can we fix this instead of excluding it? This is a true positive. Do we care? |
@elharo I don't think we can fix it. It is true positive while gRPC users do not suffer from this. The reference is from shaded Netty for the (unused) compression algorithm. |
Thank you. |
I am using Apache beam with grpc and dataflow. 1.29.0 and 3.12.2, facing same issue. any solution for this. |
@reachlakstar The class does not seem gax-java. Would you create an issue in Beam's issue management with your pom.xml or build.gradle, and give me the URL? |
aftects: googleapis/java-pubsub#217