From d002a940bd6455c87b6c7086959b960850223a2a Mon Sep 17 00:00:00 2001 From: Neenu1995 Date: Tue, 16 Nov 2021 13:47:10 -0500 Subject: [PATCH 1/6] deps: update grpc to 1.42.1 --- dependencies.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dependencies.properties b/dependencies.properties index ae483f64d..fd1b090f8 100644 --- a/dependencies.properties +++ b/dependencies.properties @@ -25,7 +25,7 @@ version.gax_httpjson=0.92.1-SNAPSHOT # with the sources. version.com_google_protobuf=3.18.1 version.google_java_format=1.1 -version.io_grpc=1.41.0 +version.io_grpc=1.42.1 # Maven artifacts. # Note, the actual name of each property matters (bazel build scripts depend on it). From b656ba8a4e7144cbc5663f1e96fd00dc914f322e Mon Sep 17 00:00:00 2001 From: Neenu1995 Date: Tue, 16 Nov 2021 17:48:18 -0500 Subject: [PATCH 2/6] test: print bazel version --- .github/workflows/ci.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 99705fa63..58aeea1c0 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -53,7 +53,9 @@ jobs: echo "The old one will disappear after 7 days." - name: Run bazel tests - run: bazel --batch test //... --noshow_progress --test_output=errors + run: | + bazel --version + bazel --batch test //... --noshow_progress --test_output=errors - uses: actions/upload-artifact@v2 if: ${{ failure() }} From d9be70d1d4a0dc2a07138758984dd31a0050f467 Mon Sep 17 00:00:00 2001 From: Neenu1995 Date: Tue, 16 Nov 2021 17:49:55 -0500 Subject: [PATCH 3/6] deps: update protobuf version to 3.19.1 --- dependencies.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dependencies.properties b/dependencies.properties index fd1b090f8..5d5d2cf1c 100644 --- a/dependencies.properties +++ b/dependencies.properties @@ -23,7 +23,7 @@ version.gax_httpjson=0.92.1-SNAPSHOT # Versions for dependencies which actual artifacts differ between Bazel and Gradle. # Gradle build depends on prebuilt maven artifacts, while Bazel build depends on Bazel workspaces # with the sources. -version.com_google_protobuf=3.18.1 +version.com_google_protobuf=3.19.1 version.google_java_format=1.1 version.io_grpc=1.42.1 From e4f73339c361e9d2c2f5a89866df45047e465c5c Mon Sep 17 00:00:00 2001 From: Neenu Shaji Date: Fri, 19 Nov 2021 12:55:36 -0500 Subject: [PATCH 4/6] test: try googleapis container gcr.io/gapic-images/googleapis:latest --- .github/workflows/ci.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 58aeea1c0..a5fe3ee92 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -22,7 +22,7 @@ jobs: bazel: runs-on: ubuntu-latest - container: gcr.io/gapic-images/googleapis-bazel:20210105 + container: gcr.io/gapic-images/googleapis:latest steps: - uses: actions/checkout@v2 - uses: actions/setup-java@v1 @@ -54,6 +54,7 @@ jobs: - name: Run bazel tests run: | + which bazel bazel --version bazel --batch test //... --noshow_progress --test_output=errors From 05c412e2f1765534d95c55f2ef8e38e2619e9e67 Mon Sep 17 00:00:00 2001 From: Neenu Shaji Date: Fri, 19 Nov 2021 13:04:34 -0500 Subject: [PATCH 5/6] test: try using no container --- .github/workflows/ci.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index a5fe3ee92..cab8c0895 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -22,7 +22,6 @@ jobs: bazel: runs-on: ubuntu-latest - container: gcr.io/gapic-images/googleapis:latest steps: - uses: actions/checkout@v2 - uses: actions/setup-java@v1 From 89caae00efd956d78d5314e1c7914530531ab4a1 Mon Sep 17 00:00:00 2001 From: Tomo Suzuki Date: Mon, 29 Nov 2021 13:49:39 -0500 Subject: [PATCH 6/6] chore: clarified comment on not using container in Bazel build --- .github/workflows/ci.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index cab8c0895..bac301924 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -22,6 +22,9 @@ jobs: bazel: runs-on: ubuntu-latest + # Not using a container. The ubuntu-latest has Bazel 4.2 installed as of + # November 2021. gRPC 1.42 requires Bazel 4. + # https://github.com/grpc/grpc-java/pull/7598 steps: - uses: actions/checkout@v2 - uses: actions/setup-java@v1