Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Update repository_rules.bzl #730

Merged
merged 1 commit into from Sep 4, 2019
Merged

Conversation

cgrinker
Copy link
Contributor

@cgrinker cgrinker commented Jun 5, 2019

Adding starlark string coercion to fix error: unsupported operand type(s) for +: 'string' and 'int'

Discussion

This error hides the real error code when trying to read in the attributes file

I proced this error building the //google/api:annotations_proto rule in the googleapis/googleapis repository. The api_annotations and swagger gen rules are used int the googleforgames/open-match project, whose protocol buffer rules I'm trying to run.

Adding starlark string coercion to fix error: `unsupported operand type(s) for +: 'string' and 'int'`

## Discussion
This error hides the real error code when trying to read in the attributes file
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 5, 2019
@cgrinker
Copy link
Contributor Author

cgrinker commented Jun 5, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 5, 2019
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #730 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #730   +/-   ##
=========================================
  Coverage     77.43%   77.43%           
  Complexity     1081     1081           
=========================================
  Files           196      196           
  Lines          4707     4707           
  Branches        369      369           
=========================================
  Hits           3645     3645           
  Misses          895      895           
  Partials        167      167

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aaa370...dfd0d3b. Read the comment docs.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 12, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Jul 3, 2019
@vam-google vam-google self-requested a review September 4, 2019 22:12
@vam-google vam-google added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Sep 4, 2019
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vam-google
Copy link
Contributor

vam-google commented Sep 4, 2019

@cgrinker Thanks a lot for fixing this! I believe nobody has ever seen this pull request (it does not have a corresponding issue and was not assigned to anyone), that is why it was ignored.

Merging in

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants