Conversation
Adding starlark string coercion to fix error: `unsupported operand type(s) for +: 'string' and 'int'` ## Discussion This error hides the real error code when trying to read in the attributes file
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
=========================================
Coverage 77.43% 77.43%
Complexity 1081 1081
=========================================
Files 196 196
Lines 4707 4707
Branches 369 369
=========================================
Hits 3645 3645
Misses 895 895
Partials 167 167 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cgrinker Thanks a lot for fixing this! I believe nobody has ever seen this pull request (it does not have a corresponding issue and was not assigned to anyone), that is why it was ignored. Merging in |
Adding starlark string coercion to fix error:
unsupported operand type(s) for +: 'string' and 'int'
Discussion
This error hides the real error code when trying to read in the attributes file
I proced this error building the
//google/api:annotations_proto
rule in thegoogleapis/googleapis
repository. The api_annotations and swagger gen rules are used int the googleforgames/open-match project, whose protocol buffer rules I'm trying to run.