Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

update google-auth-library to 0.17.2 #789

Merged
merged 2 commits into from Sep 26, 2019

Conversation

chingor13
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2019
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #789 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #789      +/-   ##
============================================
- Coverage     78.39%   78.37%   -0.03%     
+ Complexity     1106     1105       -1     
============================================
  Files           198      198              
  Lines          4887     4887              
  Branches        385      385              
============================================
- Hits           3831     3830       -1     
  Misses          887      887              
- Partials        169      170       +1
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/api/gax/batching/BatcherImpl.java 97.2% <0%> (-0.7%) 14% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dfae40...93aa081. Read the comment docs.

@chingor13
Copy link
Contributor Author

Codecov's coverage seems incorrect here

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elharo
Copy link
Contributor

elharo commented Sep 26, 2019

Yes, I don't think codecov is accurate to 4 significant digits. We should probably loosen that check a bit.

@chingor13 chingor13 merged commit 508cffc into googleapis:master Sep 26, 2019
@chingor13 chingor13 deleted the update-auth branch September 26, 2019 19:53
This was referenced Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants