update travis to trusty #799
Conversation
googlebot
added
the
cla: yes
|
We could use Log from xenial
@elharo thoughts? |
|
If we use openjdk7, that's good enough. We don't want to drop support for Java 7 completely. |
|
Trusty probably works better than xenial for now. |
Switching to test only against OpenJDK as support in travis has shifted. Fixes: googleapis#793
codyoss
force-pushed
the
travis-upgrade
branch
from
eb1957f
to
3ce040e
Compare
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
=========================================
Coverage 78.39% 78.39%
Complexity 1106 1106
=========================================
Files 198 198
Lines 4887 4887
Branches 385 385
=========================================
Hits 3831 3831
Misses 887 887
Partials 169 169Continue to review full report at Codecov.
|
| language: java | ||
| addons: | ||
| # https://github.com/travis-ci/travis-ci/issues/5227#issuecomment-165131913 | ||
| hosts: | ||
| - fake-hostname-to-work-around-travis-bug | ||
| hostname: fake-hostname-to-work-around-travis-bug | ||
| jdk: | ||
| - oraclejdk8 | ||
| - oraclejdk7 | ||
| - openjdk8 |
There was a problem hiding this comment.
This removes removes Oracle's JDKs from tests completely. Why do we have to do it?
Not having Oracle SDKs tested at all seems too much. Can we manually download it as part of test script and still test?
It seems like we should just drop java 7 support at this point. Supporting it makes less and less sense.
|
@elharo Why do we still want to support Java 7? It seem like it is getting banned from everywhere to the extent that it is even problematic to setup a test infrastructure where java 7 is allowed. |
|
We want it because we have paying customers that use it, and it's still a supported environment for App Engine. One year I'm sure we'll drop it, but that's a much bigger discussion to be had. |
Fixes: #793