Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

[bazel] Fix Bazel 1.0.0 incompatibility issue #803

Merged
merged 1 commit into from Oct 11, 2019

Conversation

vam-google
Copy link
Contributor

@vam-google vam-google commented Oct 11, 2019

Maxsplit is now a positional argument in string.split(). It seems like the only incompatibility issue between 0.28.1 and 1.0.0

Maxsplit is now a positional argument in string.split(). It seems like the only incompatibility issue between 0.28.1.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2019
@vam-google vam-google changed the title Fix Bazel 1.0.0 incompatibility issue. Fix Bazel 1.0.0 incompatibility issue Oct 11, 2019
@vam-google vam-google changed the title Fix Bazel 1.0.0 incompatibility issue [bazel] Fix Bazel 1.0.0 incompatibility issue Oct 11, 2019
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #803 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #803   +/-   ##
=========================================
  Coverage     78.39%   78.39%           
  Complexity     1106     1106           
=========================================
  Files           198      198           
  Lines          4887     4887           
  Branches        385      385           
=========================================
  Hits           3831     3831           
  Misses          887      887           
  Partials        169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a844c...e201bf4. Read the comment docs.

Copy link
Contributor

@yihanzhen yihanzhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vam-google vam-google merged commit 31b44b1 into googleapis:master Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants