Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

chore(deps): update GSON and Guava #843

Merged
merged 2 commits into from Jan 13, 2020
Merged

chore(deps): update GSON and Guava #843

merged 2 commits into from Jan 13, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jan 9, 2020 •
edited

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 9, 2020
@codecov
Copy link

codecov bot commented Jan 9, 2020 •
edited

Codecov Report

Merging #843 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #843   +/-   ##
=========================================
  Coverage     78.62%   78.62%           
  Complexity     1163     1163           
=========================================
  Files           203      203           
  Lines          5142     5142           
  Branches        413      413           
=========================================
  Hits           4043     4043           
  Misses          925      925           
  Partials        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5500034...e646f7b. Read the comment docs.

@elharo elharo requested a review from kolea2 January 9, 2020 22:00
kolea2
kolea2 approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @chingor13 @codyoss any idea why renovate bot isn't doing this for us?

@elharo
Copy link
Contributor Author

elharo commented Jan 13, 2020

Renovabot picks the wrong jre version of Guava.

@elharo elharo merged commit ee3540a into master Jan 13, 2020
@elharo elharo deleted the elharo-patch-2 branch January 13, 2020 15:53
@chingor13 chingor13 mentioned this pull request Jan 30, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kolea2 kolea2 kolea2 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elharo @kolea2 @googlebot