Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

deps: update grpc to 1.27.0, google-auth-library to 0.20.0 #861

Merged
merged 2 commits into from Jan 30, 2020
Merged

deps: update grpc to 1.27.0, google-auth-library to 0.20.0 #861

merged 2 commits into from Jan 30, 2020

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jan 30, 2020 •
edited

grpc to 1.27.0
google-auth-library to 0.20.0

@chingor13
update core dependencies
f478c9b 
google-http-client to 1.34.1
grpc to 1.27.0
google-auth-library to 0.20.0
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2020
@chingor13 chingor13 requested a review from a team January 30, 2020 18:00
@codecov
Copy link

codecov bot commented Jan 30, 2020 •
edited

Codecov Report

Merging #861 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #861   +/-   ##
=========================================
  Coverage     78.62%   78.62%           
  Complexity     1163     1163           
=========================================
  Files           203      203           
  Lines          5142     5142           
  Branches        413      413           
=========================================
  Hits           4043     4043           
  Misses          925      925           
  Partials        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a43ed...fd6ce42. Read the comment docs.

@chingor13 chingor13 requested a review from elharo January 30, 2020 18:24
elharo
elharo reviewed Jan 30, 2020
View reviewed changes
dependencies.properties Outdated
@@ -49,8 +49,8 @@ maven.com_google_api_api_common=com.google.api:api-common:1.8.1
maven.org_threeten_threetenbp=org.threeten:threetenbp:1.4.0
maven.com_google_api_grpc_grpc_google_iam_v1=com.google.api.grpc:grpc-google-iam-v1:0.13.0
maven.com_google_api_grpc_proto_google_iam_v1=com.google.api.grpc:proto-google-iam-v1:0.13.0
maven.com_google_http_client_google_http_client=com.google.http-client:google-http-client:1.34.0
maven.com_google_http_client_google_http_client_jackson2=com.google.http-client:google-http-client-jackson2:1.34.0
maven.com_google_http_client_google_http_client=com.google.http-client:google-http-client:1.34.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't update libraries-bom to 1.34.1 until we push some changes in either protobuf-java or java-core, possibly both. Could we hold off on this one until those are done?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java-core has released with http-client 1.34.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change we need pushed from java-core is actually googleapis/java-core#140. Otherwise errorprone fails the upper bounds check.

@BenWhitehead BenWhitehead mentioned this pull request Jan 30, 2020
Merged
1 task
@chingor13 chingor13 changed the title deps: update core dependencies deps: update grpc to 1.27.0, google-auth-library to 0.20.0 Jan 30, 2020
@chingor13 chingor13 merged commit 6b207e5 into master Jan 30, 2020
@chingor13 chingor13 deleted the chingor13-patch-1 branch January 30, 2020 20:19
@chingor13 chingor13 mentioned this pull request Jan 30, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elharo elharo elharo approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chingor13 @elharo @googlebot