Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

fix: do not shut down executor when WatchDog is shut down #871

Merged
merged 1 commit into from Feb 18, 2020
Merged

fix: do not shut down executor when WatchDog is shut down #871

merged 1 commit into from Feb 18, 2020

Conversation

chrisribble
Copy link
Contributor

Fixes #870

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 13, 2020
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #871 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #871      +/-   ##
============================================
- Coverage     78.62%   78.62%   -0.01%     
  Complexity     1163     1163              
============================================
  Files           203      203              
  Lines          5142     5141       -1     
  Branches        413      413              
============================================
- Hits           4043     4042       -1     
  Misses          925      925              
  Partials        174      174
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/api/gax/rpc/Watchdog.java 80.34% <ø> (-0.17%) 11 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee90c2c...fa2ff44. Read the comment docs.

@chrisribble
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 13, 2020
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for fixing this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WatchDog shuts down ExecutorService from FixedExecutorProvider
3 participants