Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @grpc/grpc-js version to ~1.7.1 #1370

Closed
antonstefer opened this issue Sep 21, 2022 · 1 comment
Closed

Bump @grpc/grpc-js version to ~1.7.1 #1370

antonstefer opened this issue Sep 21, 2022 · 1 comment
Assignees
@sofisl
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@antonstefer
Copy link

See this issue: grpc/grpc-node#2231

Leaving the version constraint at ~1.7.0 would already install 1.7.1 in a clean project. In real world projects resolving peer dependencies could still result in the old slow version. Therefore I would like the dependency to be pinned to ~1.7.1
@antonstefer antonstefer added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 21, 2022
@sofisl sofisl self-assigned this Sep 23, 2022
@leahecole
Copy link
Contributor

Closing as obsolete, we now depend on ~1.10.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sofisl sofisl

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leahecole @sofisl @antonstefer