Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gax-nodejs an ESM compatible package #1443

Open
josephperrott opened this issue Apr 21, 2023 · 2 comments
Open

Make gax-nodejs an ESM compatible package #1443

josephperrott opened this issue Apr 21, 2023 · 2 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@josephperrott
Copy link

josephperrott commented Apr 21, 2023

Thanks for stopping by to let us know something could be better!

Is your feature request related to a problem? Please describe.
Currently this library does not integrate into other ESM usages cleanly

Describe the solution you'd like
gax-nodejs publishes new versions which are ESM compatible.

Describe alternatives you've considered
Nothing is really available as an alternative, besides staying on CJS. Unfortunately this is not an option long term as the ecosystem moves forward.

@josephperrott josephperrott added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 21, 2023
@sofisl
Copy link
Contributor

sofisl commented Apr 27, 2023

@alexander-fenster, what would you think about releasing this as dual-format, CJS and ESM? If so, we'd need to do it in the next major bump.

@josephperrott, FYI we wouldn't be able to make this just ESM, or else it would break consumers of this library (gapics). But it would potentially be possible for us to publish this in dual-format.

@alexander-fenster
Copy link
Contributor

A possible alternative would be to release into two separate packages, one for ESM, another one for CJS, but it's not really clear how we would manage that in the libraries unless we also publish each of them separately as both ESM and CJS (which we probably won't do).

I'm assuming the only way forward here is to publish a combined package (2x code size), and then drop CJS in some later major version bump.

@alexander-fenster alexander-fenster removed their assignment May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants