Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streaming: emit response when stream received metadata event failed #1451

Open
flaky-bot bot opened this issue May 21, 2023 · 1 comment
Open

streaming: emit response when stream received metadata event failed #1451

flaky-bot bot opened this issue May 21, 2023 · 1 comment
Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented May 21, 2023

Note: #1403 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: 064e131
buildURL: Build Status, Sponge
status: failed

Test output
Expected values to be strictly deep-equal:
+ actual - expected

{
code: 200,
details: '',
message: 'OK',

  • metadata: {

  • metadata: true
    
  • }
    }

    • expected - actual

    {
    "code": 200
    "details": ""
    "message": "OK"

    • "metadata": {
    • "metadata": true
    • }
      }

/workspace/test/unit/streaming.ts:363
assert.deepStrictEqual(receivedResponse, expectedResponse);
^

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:

  • actual - expected

    {
    code: 200,
    details: '',
    message: 'OK',

  • metadata: {
  • metadata: true
    
  • }
    }
    at null.check (test/unit/streaming.ts:363:16)
    at StreamProxy. (test/unit/streaming.ts:377:7)
    at Immediate._onImmediate (test/unit/streaming.ts:334:11)
    at processImmediate (internal/timers.js:464:21)
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. labels May 21, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented May 22, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (064e131), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@danieljbruce danieljbruce added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 23, 2023
feywind pushed a commit to feywind/gax-nodejs that referenced this issue Jul 11, 2023
…#1451) (googleapis#1277)

Source-Link: googleapis/synthtool@cd78529
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:ddb19a6df6c1fa081bc99fb29658f306dd64668bc26f75d1353b28296f3a78e6
@alexander-fenster alexander-fenster removed their assignment May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants