Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: upgrade engines field to >=8.10.0 #483

Merged
merged 2 commits into from May 2, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 2, 2019

This drops support for all Node.js versions < 8.10.0, please upgrade

BREAKING CHANGE: library now requires Node >= 8.10.0

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2019
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #483 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
- Coverage   82.43%   82.36%   -0.08%     
==========================================
  Files          50       50              
  Lines        3439     3419      -20     
  Branches      266      257       -9     
==========================================
- Hits         2835     2816      -19     
  Misses        539      539              
+ Partials       65       64       -1
Impacted Files Coverage Δ
src/index.ts 86.36% <0%> (-4.27%) ⬇️
src/bundlingCalls/bundleExecutor.ts 86.58% <0%> (-0.48%) ⬇️
src/grpc.ts 85.04% <0%> (-0.28%) ⬇️
src/longRunningCalls/longrunning.ts 96.36% <0%> (-0.04%) ⬇️
src/bundlingCalls/task.ts 97.72% <0%> (-0.03%) ⬇️
src/createApiCall.ts 90.47% <0%> (ø) ⬆️
src/streamingCalls/streamingApiCaller.ts 77.77% <0%> (ø) ⬆️
test/utils.ts 92% <0%> (ø) ⬆️
src/descriptor.ts 100% <0%> (ø) ⬆️
test/grpc.ts 92.94% <0%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6331def...1a68467. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 728678a into master May 2, 2019
@JustinBeckwith JustinBeckwith deleted the update-engine-field-2-the-updates-revenge branch May 2, 2019 18:27
@release-please release-please bot mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants