Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support socks5 proxy #211

Open
muzuiget opened this issue Dec 29, 2019 · 3 comments
Open

support socks5 proxy #211

muzuiget opened this issue Dec 29, 2019 · 3 comments
Assignees
@ddelgrosso1
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@muzuiget
Copy link

Currently gaxios not support https_proxy environment variable like socks5://127.0.0.1:8080. I did a litte hack on the code, just change the file https://github.com/googleapis/gaxios/blob/v2.2.0/src/gaxios.ts#L60

HttpsProxyAgent = require('https-proxy-agent');

to

HttpsProxyAgent = require('proxy-agent');

Then it work fine.

proxy-agent also write by the https-proxy-agent author.
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Dec 29, 2019
@bcoe bcoe added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Dec 30, 2019
@bcoe bcoe changed the title [Feature request] support socks5 proxy support socks5 proxy Dec 30, 2019
@bcoe
Copy link
Contributor

bcoe commented Dec 30, 2019

thanks for the suggestion @muzuiget 👍

@yoshi-automation yoshi-automation removed triage me I really want to be triaged. triage me labels Dec 31, 2019
@danielbankhead
Copy link
Member

Related:

@danielbankhead
Copy link
Member

If we migrate to fetch this may be an upstream blocker:

PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddelgrosso1 ddelgrosso1

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bcoe @muzuiget @danielbankhead @yoshi-automation @ddelgrosso1