Default validateStatus function should print HTTP response body on error

[ace-n]

Current behavior
If an HTTP request returns an invalid status code, gaxios will return a Request Failed with status code <CODE> error. (Relevant code here)

This doesn't give me lots of information as to why the error occurred (without wrapping the request call in a try...except block - this feels clunky IMHO), which is useful when debugging.

Expected behavior
gaxios should include the HTTP response body in the message - something like:

Error: Request failed with status code 500

Body:
  Some error occurred. Here is where the details should go.

Alternatively, validateStatus could be an opt-in behavior to allow for manual assertion of status code and/or response contents.

Workaround
In the meantime, I've been working around this by using a custom validateStatus function set to True.

[sofisl]

This sounds reasonable enough to me, @bcoe do you have any thoughts on this request?

[bcoe]

Agreed, seems like a reasonable request to me, @ace-n do you have a specific example of an error you were receiving so that we could see if the error was improved by this addition?

[ace-n]

Create a Cloud Function like this:

exports.helloWorld = (req, res) => {
  res.status(404).send("Elvis has left the building").end();
};

Then, request it like this:

const x = async () => {
  const {request} = require('gaxios');
  const res = await request({
    url: '<FUNCTION_URL>'
  });
  console.log(res)
}

x()

It doesn't tell me that Elvis has left the building. 🎤