Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support encoding #58

Closed
nguymin4 opened this issue Mar 13, 2019 · 1 comment · Fixed by googleapis/google-api-nodejs-client#1765
Closed

Support encoding #58

nguymin4 opened this issue Mar 13, 2019 · 1 comment · Fixed by googleapis/google-api-nodejs-client#1765
Assignees
@JustinBeckwith
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@nguymin4
Copy link

nguymin4 commented Mar 13, 2019 •
edited

Hi @JustinBeckwith,

In your PR for googleapis googleapis/google-api-nodejs-client#1558, it's written that gaxios supports encoding option. But I don't see it anywhere in gaxios. Am I misunderstanding something here?

Thanks
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me labels May 1, 2019
@JustinBeckwith JustinBeckwith added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed enhancement 🚨 This issue needs some love. triage me I really want to be triaged. labels May 13, 2019
@JustinBeckwith JustinBeckwith mentioned this issue Jul 19, 2019
Merged
@JustinBeckwith
Copy link
Contributor

Greetings! Those were some out dated docs...
googleapis/google-api-nodejs-client#1765

there's no encoding option directly on gaxios.

@JustinBeckwith JustinBeckwith self-assigned this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update docs and samples for drive export googleapis/google-api-nodejs-client
3 participants
@JustinBeckwith @nguymin4 @yoshi-automation