Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated timeout Implementation and Documentation #602

Open
rhodgkins opened this issue Feb 9, 2024 · 1 comment
Open

feat: Updated timeout Implementation and Documentation #602

rhodgkins opened this issue Feb 9, 2024 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@rhodgkins
Copy link

Is the timeout option used at all?

timeout?: number;

From a quick search and scan of the code I can't see how it's used? It's not an option in node-fetch either...

@rhodgkins rhodgkins added priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue. labels Feb 9, 2024
@danielbankhead danielbankhead removed the type: question Request for information or clarification. Not an issue. label Feb 15, 2024
@danielbankhead
Copy link
Member

It looks like it was passed to node-fetch v2 here:

gaxios/src/gaxios.ts

Lines 139 to 142 in 8490f24

const fetchImpl = opts.fetchImplementation || fetch;
const res = (await fetchImpl(opts.url!, opts)) as FetchResponse;
const data = await this.getResponseData(opts, res);
return this.translateResponse<T>(opts, res, data);

However, we should update this to work with any fetch implementation - I'll convert this to a feature request.

Implementation Notes

@danielbankhead danielbankhead added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels Feb 15, 2024
@danielbankhead danielbankhead changed the title timeout usage feat: Updated timeout Implementation and Documentation Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants