Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transport): add support for setting quota project with envvar #1892

Merged
merged 10 commits into from Mar 10, 2023
Merged

feat(transport): add support for setting quota project with envvar #1892

merged 10 commits into from Mar 10, 2023

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Mar 6, 2023

Fixes: #1891

@codyoss codyoss requested a review from quartzmo March 6, 2023 17:40
@codyoss codyoss requested review from a team and yoshi-approver as code owners March 6, 2023 17:40
quartzmo
quartzmo reviewed Mar 8, 2023
View reviewed changes
internal/creds_test.go Outdated Show resolved Hide resolved
@codyoss codyoss requested a review from quartzmo March 8, 2023 21:30
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Mar 8, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 9, 2023
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Mar 9, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 9, 2023
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Mar 10, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 63c48a6 into googleapis:main Mar 10, 2023
3 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 10, 2023
@release-please release-please bot mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow setting quota project with GOOGLE_CLOUD_QUOTA_PROJECT
2 participants
@codyoss @quartzmo