Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(all): auto-regenerate discovery clients #2054

Merged
merged 1 commit into from Jul 6, 2023
Merged

feat(all): auto-regenerate discovery clients #2054

merged 1 commit into from Jul 6, 2023

Conversation

yoshi-automation
Copy link
Contributor

No description provided.

@yoshi-approver yoshi-approver added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 6, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 6, 2023
@codyoss
Copy link
Member

codyoss commented Jul 6, 2023 •
edited

@noahdietz not sure why this did not work. Might need to look into automation...

@noahdietz
Copy link
Contributor

@noahdietz not sure why this did not work. Might need to look into automation...

Thanks yeah, my guess is that the yoshi-approver user lots codeowners/whatever role it needed somehow...

@noahdietz
Copy link
Contributor

@codyoss the go.work.sum changed, which yoshi-approvers doesn't have CODEOWNERS on. Do you think it is OK to give it such power? Or is there something in our automation here we need to tweak to prevent go.work.sum updates?

@noahdietz noahdietz mentioned this pull request Jul 6, 2023
Closed
noahdietz
noahdietz approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for go.work.sum change. Filed #2055 to look into ensuring CI vets for necessary go.work.sum changes.

@noahdietz noahdietz merged commit 1b0f818 into main Jul 6, 2023
6 checks passed
@noahdietz noahdietz deleted the discogen branch July 6, 2023 23:22
@release-please release-please bot mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

@yoshi-approver yoshi-approver yoshi-approver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yoshi-automation @codyoss @noahdietz @yoshi-approver