feat: additional checks before using S2A #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
reviewed
Aug 8, 2023
go.work.sum
Outdated
| @@ -1,13 +1,286 @@ | |||
| cloud.google.com/go v0.110.0 h1:Zc8gqp3+a9/Eyph2KDmcGaPtbKRIoqq4YTlL4NMD0Ys= | |||
| cloud.google.com/go v0.110.2 h1:sdFPBr6xG9/wkBbfhmUz/JmZC7X6LavQgcrVINrKiVA= | |||
| cloud.google.com/go v0.110.4 h1:1JYyxKMN9hd5dR2MYTPWkGUgcoxVVhg0LKNKEo0qvmk= | |||
| cloud.google.com/go v0.110.4/go.mod h1:+EYjdK8e5RME/VY/qLCAtuyALQ9q67dvuum8i+H5xsI= | |||
There was a problem hiding this comment.
I am not familiar with this code base, but should this file be updated separately?
Are all of these dependencies being updated?
There was a problem hiding this comment.
I'm asking someone familiar with the repo to take a look
There was a problem hiding this comment.
Can you just revert this, update your branch and double check that everything is in order? I might need to just manually update this on main so that you don't need to change this.
There was a problem hiding this comment.
Thanks @noahdietz I reverted changes to this file. PTAL
clundin25
reviewed
Aug 8, 2023
clundin25
reviewed
Aug 8, 2023
|
@xmenxk can you fix the conventional commit error? |
clundin25
approved these changes
Aug 8, 2023
noahdietz
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
codyoss
changed the title
codyoss
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a couple more checks before using S2A for mtls
DefaultMTLSEndpointis not empty