Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove process for appengine #2128

Closed
komem3 opened this issue Sep 1, 2023 · 2 comments · Fixed by #2158
Closed

Remove process for appengine #2128

komem3 opened this issue Sep 1, 2023 · 2 comments · Fixed by #2158
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@komem3
Copy link

komem3 commented Sep 1, 2023

Is your feature request related to a problem? Please describe.

When deploying to Appengine, I get the following warning even though the source does not use the Appengine API. This may be due to the fact that this package depends on the appengine api.

Beginning deployment of service [default]...
╔════════════════════════════════════════════════════════════╗
╠═ Uploading 20 files to Google Cloud Storage               ═╣
╚════════════════════════════════════════════════════════════╝
File upload done.
WARNING: There is an indirect dependency on App Engine APIs, but they are not enabled in your app.yaml. You may see runtime errors trying to access these APIs. Set the app_engine_apis property.
go mod why google.golang.org/appengine
# google.golang.org/appengine
# remove my repository
cloud.google.com/go/secretmanager/apiv1
google.golang.org/api/transport/grpc
google.golang.org/appengine

Describe the solution you'd like

I want you to remove for appengine process that uses appengine build tag.

https://github.com/search?q=repo:googleapis/google-api-go-client%20google.golang.org/appengine&type=code

Describe alternatives you've considered

These files seem to be processed for appengine, but this build tag does not seem to be used by 2gen. If it is really not used, then this process is not working in 2gen.
If this repository is only supported by 2gen, then it seems safe to delete the file.

golang/oauth2#334

@komem3 komem3 added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 1, 2023
@codyoss codyoss assigned quartzmo and unassigned codyoss Sep 1, 2023
@quartzmo
Copy link
Member

quartzmo commented Sep 1, 2023

@komem3 Thank you for reporting this issue. We will investigate if these files can be removed.

@quartzmo
Copy link
Member

Good news, we confirmed with the App Engine team that both google.golang.org/appengine/socket and google.golang.org/appengine/urlfetch packages are no longer to be used in the App Engine Go second generation runtime (>= Go 1.11). I will proceed now with a PR to remove the conditionally-built hook code.

quartzmo added a commit to quartzmo/google-api-go-client that referenced this issue Sep 12, 2023
* Remove gRPC hook for google.golang.org/appengine/socket
* Remove HTTP hook for google.golang.org/appengine/urlfetch

Both hooks load packages that are no longer intended for use in the
App Engine Go second generation runtime (>= Go 1.11).

closes: googleapis#2128
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 12, 2023
* Remove gRPC hook for google.golang.org/appengine/socket
* Remove HTTP hook for google.golang.org/appengine/urlfetch

Both hooks load packages that are no longer intended for use in the App Engine Go second generation runtime (>= Go 1.11).

closes: #2128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants