feat: add hooks in for new auth library #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
force-pushed
the
auth-changes
branch
5 times, most recently
from
8cb6e02
to
5e638cd
Compare
quartzmo
approved these changes
Oct 20, 2023
codyoss
added
the
do not merge
quartzmo
requested changes
Mar 11, 2024
codyoss
removed
the
do not merge
codyoss
added
the
do not merge
codyoss
removed
the
do not merge
quartzmo
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All code that calls into the old base auth layer can not optionally call into the new stack. Where possible, packages call into new auth packages directly. As a fallback, and for cases where we don't have 1-1 replacements the code in internal should ensure that at least the ADC logic from the new auth stack is called into.
Flipping the environment variable on for this repo so we make sure that all tests currently written pass without any code changes. This should give confidence that when options are in place to call into the new stack code continues to work as is without any code changes.