Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISS validation to the idToken validator #2248

Closed
anton-kstnk opened this issue Nov 3, 2023 · 2 comments
Closed

Add ISS validation to the idToken validator #2248

anton-kstnk opened this issue Nov 3, 2023 · 2 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@anton-kstnk
Copy link

anton-kstnk commented Nov 3, 2023

In these docs I found the following line:
The value of iss in the ID token is equal to accounts.google.com or https://accounts.google.com.

I couldn't find this check inside the go client lib.

@anton-kstnk anton-kstnk added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 3, 2023
@quartzmo
Copy link
Member

quartzmo commented Nov 3, 2023

@anton-kstnk Thanks for reporting this. I agree that it looks like an omission in the idtoken Validator.

@codyoss Is there any reason why we shouldn't add this? Does this library support other issuers?

@quartzmo quartzmo added type: question Request for information or clarification. Not an issue. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 3, 2023
@codyoss codyoss assigned quartzmo and unassigned codyoss Nov 6, 2023
@codyoss
Copy link
Member

codyoss commented Apr 24, 2024

Closing this in favor of #2422 which goes into a little more detail on other possible validations as well. Thanks for raising this.

@codyoss codyoss closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

3 participants