Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transport/grpc): add universe domain verification #2375

Merged
merged 2 commits into from Jan 25, 2024
Merged

fix(transport/grpc): add universe domain verification #2375

merged 2 commits into from Jan 25, 2024

Conversation

quartzmo
Copy link
Member

No description provided.

@quartzmo quartzmo requested a review from a team as a code owner January 25, 2024 19:14
noahdietz
noahdietz approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments but LGTM otherwise

internal/creds.go Show resolved Hide resolved
internal/creds.go Outdated Show resolved Hide resolved
@quartzmo quartzmo merged commit df17254 into googleapis:main Jan 25, 2024
5 checks passed
@quartzmo quartzmo deleted the transport-grpc-universe-domain branch January 25, 2024 20:04
@release-please release-please bot mentioned this pull request Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quartzmo @noahdietz