fix: use reject handler instead of catch for callbacks (#1161)

googleapis · May 11, 2018 · 25c3f8e · 25c3f8e
1 parent f3347c5
commit 25c3f8e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/samples/urlshortener/urlshortener.js b/samples/urlshortener/urlshortener.js
@@ -18,7 +18,11 @@ const path = require('path');
 const nconf = require('nconf');
 
 nconf.argv().env().file(path.join(__dirname, '../config.json'));
-const urlshortener = google.urlshortener('v1', nconf.get('api_key'));
+
+const urlshortener = google.urlshortener({
+  version: 'v1',
+  auth: nconf.get('api_key')
+});
 
 urlshortener.url.get({
   shortUrl: 'http://goo.gl/DdUKX'

diff --git a/src/lib/apirequest.ts b/src/lib/apirequest.ts
@@ -59,9 +59,7 @@ export function createAPIRequest<T>(
     parameters: APIRequestParams, callback?: BodyResponseCallback<T>): void|
     AxiosPromise<T> {
   if (callback) {
-    createAPIRequestAsync<T>(parameters)
-        .then(r => callback(null, r))
-        .catch(e => callback(e));
+    createAPIRequestAsync<T>(parameters).then(r => callback(null, r), callback);
   } else {
     return createAPIRequestAsync(parameters);
   }