fix: use requestBody instead of resource
#1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
gentle ping @alexander-fenster |
| * using `resource` for reasons of back-compat. Cases that need to be covered | ||
| * here: | ||
| * - user provides just a `resource` with a request body | ||
| * - user provides both a `resource` and a `resource_` |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
alexander-fenster
approved these changes
May 8, 2018
|
😛 |
DaniilShmelev
referenced
this pull request
in DaniilShmelev/gplay-release-diff
Sep 24, 2021
DaniilShmelev
referenced
this pull request
in DaniilShmelev/gplay-release-diff
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backwards compatible change that changes the
resourcespecial case name torequestBody. Doing this for 2 reasons:It's fairly common to have a
resourceparameter required independent of the body. We have a janky thing right now where we force clients to useresource_in this case, which is neither obvious nor well documented.requestBodydoes a better job of explaining what this object actually is and what it does.Resolves #721