Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run the generator, fixing samples #1197

Merged
merged 2 commits into from Jun 2, 2018

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented May 29, 2018

This fixes the samples from var google = require() to
const {google} = require().

But npm test fails. Can anybody else run make generate and see if they have better luck?

  101 passing (12s)
  1 failing

  1) GoogleApis#discover
       should generate all apis:
     AssertionError [ERR_ASSERTION]: API 'resourceviews' is not available on GoogleApis
      at localApis.forEach (test/test.discover.ts:46:13)
      at Array.forEach (<anonymous>)
      at Context.it (test/test.discover.ts:45:15)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 29, 2018
@JustinBeckwith
Copy link
Contributor

Thanks for doing this! A few things to try:

  • I know this is lame, but can you try running the generator again? Sometimes that makes the missing API re-appear magically.
  • In the PR title - can you update it to use convention commit status? Something like `chore: run the generator' is good :)

@fhinkel fhinkel force-pushed the make-generate-for-correct-require-in-samples branch 2 times, most recently from 096e2d2 to 50e2d6c Compare May 31, 2018 14:53
@fhinkel
Copy link
Contributor Author

fhinkel commented May 31, 2018

I started with a clean build and turned it Off and On again™️. All tests passing now. Please take a look.

@JustinBeckwith JustinBeckwith changed the title Run make generate chore: run the generator, fixing samples Jun 2, 2018
fhinkel and others added 2 commits June 1, 2018 22:45
This fixes the samples from `var google = require()` to
`const {google} = require()`.
@JustinBeckwith JustinBeckwith force-pushed the make-generate-for-correct-require-in-samples branch from 0089605 to 7782ccd Compare June 2, 2018 05:47
@JustinBeckwith JustinBeckwith merged commit e7f2ec4 into master Jun 2, 2018
@fhinkel
Copy link
Contributor Author

fhinkel commented Jun 5, 2018

Wait, is your generator better than my generator? 😄
Thanks for taking care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants