Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot read property of undefined. sampleclient.js line 42 #1242

Merged
merged 3 commits into from Jul 17, 2018

Conversation

nguyendviet
Copy link
Contributor

fix: cannot read property of undefined in sampleclient.js line 42

Added: line 32. All tests passed.

const keyFile = require(keyPath);
keys = keyFile.installed || keyFile.web;

oauth2.keys.json when downloaded looks like this:
{"installed":{
"client_id":"",
"project_id": "",
...
"redirect_uris":[...]}
}

It's also mentioned here: https://github.com/gsuitedevs/node-samples/blob/master/drive/quickstart/index.js

  • npm test succeeds
  • Pull request has been squashed into 1 commit
  • I did NOT manually make changes to anything in apis/
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate JSDoc comments were updated in source code (if applicable)
  • Appropriate changes to readme/docs are included in PR

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2018
@JustinBeckwith JustinBeckwith merged commit 4f70f4f into googleapis:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants