build!: upgrade to gts@2 #2062
Merged
build!: upgrade to gts@2 #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #2062 +/- ##
==========================================
- Coverage 38.99% 38.91% -0.08%
==========================================
Files 6 6
Lines 1072 1074 +2
Branches 7 8 +1
==========================================
Hits 418 418
- Misses 654 656 +2
Continue to review full report at Codecov.
|
| "main": "./build/src/index.js", | ||
| "types": "./build/src/index.d.ts", | ||
| "engines": { | ||
| "node": ">=10" |
There was a problem hiding this comment.
this is breaking right?
There was a problem hiding this comment.
I know I know, we do majors all the time anyway. But still.
| .authenticate(scopes) | ||
| .then(runSample) | ||
| .catch(console.error); | ||
| sampleClient.authenticate(scopes).then(runSample).catch(console.error); |
There was a problem hiding this comment.
I liked the old formatting more :) Maybe async/await here?
alexander-fenster
approved these changes
Apr 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Node 10 is now the minimum engines requirement.