Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an ESM output target #3335

Open
cramforce opened this issue Sep 4, 2023 · 0 comments · May be fixed by #3337
Open

Provide an ESM output target #3335

cramforce opened this issue Sep 4, 2023 · 0 comments · May be fixed by #3337
Assignees
@sofisl
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@cramforce
Copy link

Currently this project is written in (generates) TypeScript using esm module notation but generates CJS output.

This makes applying size optimizations to the code essentially impossible. While this package is supposed to be used on the server side, there are environments that care about impact of a module on startup time such as serverless environments and CLIs. Measured on my Macbook M1, requiring this packages currently takes about 650ms.
@cramforce cramforce added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 4, 2023
@kwonoj kwonoj linked a pull request Sep 6, 2023 that will close this issue
Open
4 tasks
@nlwillia nlwillia mentioned this issue Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sofisl sofisl

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(package): generate esm output with exports kwonoj/google-api-nodejs-client
2 participants
@cramforce @sofisl