Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include a create permission sample for the drive API #3411

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

feat: include a create permission sample for the drive API #3411

wants to merge 22 commits into from
+75 −1

Conversation

justinszaro
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3407

@justinszaro justinszaro requested a review from a team as a code owner December 30, 2023 22:11
@product-auto-label product-auto-label bot added size: m Pull request size is medium. samples Issues that are directly related to samples. labels Dec 30, 2023
@danieljbruce danieljbruce self-requested a review January 17, 2024 14:54
danieljbruce
danieljbruce reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but someone with more knowledge about this library may know if this is the correct place for these samples to be placed.

@danieljbruce danieljbruce self-requested a review January 17, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljbruce danieljbruce Awaiting requested review from danieljbruce

Assignees
No one assigned
Labels
samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a permission sample to the Drive V3 samples
2 participants
@justinszaro @danieljbruce