Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix generated documentation #3463

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elliott-king
Copy link

@elliott-king elliott-king commented Mar 27, 2024

Generated documentation was using the base directory & package.json for all libraries. Fixed the directories & package jsons to use.

It must have worked at one point, bc the doc sites have some classes as direct links.

I'm not sure npm test passes - it's timing out on my toaster.

To test:

  • On main, run npm run docs, then open one of the generated index.htmls. You will see "Google APIs Node.js Client"
  • On this branch, run npm run docs, then open a generated index.html. You should see the name of the API at the top, and the "classes" link on the left should show & work.
  • Verify that the URL paths for the "Classes" are the same as the originals.

Fixes #3460 and #3405 馃

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 27, 2024
@elliott-king elliott-king marked this pull request as ready for review March 27, 2024 21:27
@elliott-king elliott-king requested a review from a team as a code owner March 27, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js client API reference site is broken
2 participants