Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct types param name for media mime-type #1602

Merged
merged 2 commits into from Feb 19, 2019

Conversation

AVaksman
Copy link
Contributor

Fixes #1598

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2019
@AVaksman
Copy link
Contributor Author

The failing docs test is addressed in PR #1603.

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #1602 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1602   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files           2        2           
  Lines         258      258           
  Branches        2        2           
=======================================
  Hits          254      254           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd4d79...f121e86. Read the comment docs.

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@JustinBeckwith JustinBeckwith merged commit 2a7af84 into googleapis:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants