Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Remove "releasing" ToC from CONTRIBUTING.md #1607

Merged
merged 1 commit into from Feb 26, 2019
Merged

docs: Remove "releasing" ToC from CONTRIBUTING.md #1607

merged 1 commit into from Feb 26, 2019

Conversation

grant
Copy link
Contributor

@grant grant commented Feb 21, 2019 •
edited

Remove "releasing" ToC from CONTRIBUTING.md

Why?

  • Link does not exist.
  • Releasing shouldn't be done by contributors anyways.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2019
JustinBeckwith
JustinBeckwith approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@JustinBeckwith JustinBeckwith added the automerge Merge the pull request once unit tests and other checks pass. label Feb 26, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2019
@JustinBeckwith JustinBeckwith merged commit ffc5c38 into master Feb 26, 2019
@codecov
Copy link

codecov bot commented Feb 26, 2019 •
edited

Codecov Report

Merging #1607 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1607   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files           2        2           
  Lines         258      258           
  Branches        2        2           
=======================================
  Hits          254      254           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c56cb2...0ee7cf3. Read the comment docs.

@grant grant deleted the grant-contributing branch February 26, 2019 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grant @JustinBeckwith @googlebot @kokoro-team