Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run the generator #1644

Merged
merged 3 commits into from Mar 21, 2019
Merged

feat: run the generator #1644

merged 3 commits into from Mar 21, 2019

Conversation

JustinBeckwith
Copy link
Contributor

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2019
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #1644 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1644      +/-   ##
==========================================
+ Coverage   98.47%   98.47%   +<.01%     
==========================================
  Files           2        2              
  Lines         262      263       +1     
  Branches        2        2              
==========================================
+ Hits          258      259       +1     
  Misses          4        4
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7517d35...d4c67d6. Read the comment docs.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mainly adds the servicenetworking endpoint?

Left a couple notes, one oddity seemed to be that a 7 day session changed to 30 days.

* &quot;/v1/messages/{message_id}&quot; body: &quot;*&quot; }; } }
* message Message { string message_id = 1; string text = 2; }
* The following HTTP JSON to RPC mapping is enabled: HTTP | gRPC -----|-----
* `PATCH /v1/messages/123456 { &quot;text&quot;: &quot;Hi!&quot; }` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we're losing formatting on a bunch of comments somewhere along the line; seems like it's probably something that would need to be fixed upstream though?

@@ -1917,7 +1917,7 @@ export namespace fitness_v1 {
* millis since epoch). If specified, the API returns sessions modified
* since this time. The page token is ignored if either start or end time is
* specified. If none of start time, end time, and the page token is
* specified, sessions modified in the last 7 days are returned.
* specified, sessions modified in the last 30 days are returned.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting that this changed from 7 to 30 days; is this a breaking change potentially?

@JustinBeckwith
Copy link
Contributor Author

Yeah - pretty much every release in this lib is auto-generated, and most of them are major version. Will chat more later :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants