New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: run the generator #1644
feat: run the generator #1644
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1644 +/- ##
==========================================
+ Coverage 98.47% 98.47% +<.01%
==========================================
Files 2 2
Lines 262 263 +1
Branches 2 2
==========================================
+ Hits 258 259 +1
Misses 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, mainly adds the servicenetworking
endpoint?
Left a couple notes, one oddity seemed to be that a 7 day session changed to 30 days.
* "/v1/messages/{message_id}" body: "*" }; } } | ||
* message Message { string message_id = 1; string text = 2; } | ||
* The following HTTP JSON to RPC mapping is enabled: HTTP | gRPC -----|----- | ||
* `PATCH /v1/messages/123456 { "text": "Hi!" }` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like we're losing formatting on a bunch of comments somewhere along the line; seems like it's probably something that would need to be fixed upstream though?
@@ -1917,7 +1917,7 @@ export namespace fitness_v1 { | |||
* millis since epoch). If specified, the API returns sessions modified | |||
* since this time. The page token is ignored if either start or end time is | |||
* specified. If none of start time, end time, and the page token is | |||
* specified, sessions modified in the last 7 days are returned. | |||
* specified, sessions modified in the last 30 days are returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting that this changed from 7 to 30 days; is this a breaking change potentially?
Yeah - pretty much every release in this lib is auto-generated, and most of them are major version. Will chat more later :) |
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)