Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add GDCH support #1087

Merged
merged 27 commits into from Dec 6, 2022
Merged

feat: Add GDCH support #1087

merged 27 commits into from Dec 6, 2022
+1,834 −100

Conversation

poanc
Copy link
Contributor

@poanc poanc commented Nov 9, 2022 •
edited by TimurSadykov

Add support for GDCH in Java. See the Java implementation design doc for more detail: go/gdch-java-auth-lib.

GDCH for auth lib design doc and Python implementation could be found in go/gdch-python-auth-lib.

Fixes #960

@poanc poanc added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2022
@poanc poanc requested a review from a team as a code owner November 9, 2022 20:43
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Nov 9, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2022
@poanc poanc closed this Nov 10, 2022
@poanc poanc deleted the gdch branch November 10, 2022 19:22
@poanc poanc restored the gdch branch November 10, 2022 19:22
@poanc poanc reopened this Nov 10, 2022
TimurSadykov
TimurSadykov requested changes Nov 14, 2022
View reviewed changes
Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, not finished yet

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved
@poanc poanc requested a review from a team as a code owner November 17, 2022 05:29
TimurSadykov
TimurSadykov requested changes Nov 28, 2022
View reviewed changes
oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/GoogleCredentialsTest.java Outdated Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/DefaultCredentialsProviderTest.java Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java Outdated Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java Outdated Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java Outdated Show resolved Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated Show resolved Hide resolved
@poanc poanc changed the title feat: add GDCH support feat: Add GDCH support Nov 29, 2022
TimurSadykov
TimurSadykov reviewed Dec 1, 2022
View reviewed changes
Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small comments and a question

TimurSadykov
TimurSadykov approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@TimurSadykov TimurSadykov requested review from ddixit14 and blakeli0 and removed request for ddixit14 December 5, 2022 10:18
arithmetic1728
arithmetic1728 approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@arithmetic1728 arithmetic1728 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poanc poanc merged commit cfafb2d into googleapis:main Dec 6, 2022
@release-please release-please bot mentioned this pull request Dec 6, 2022
Merged
@yonghaoy yonghaoy mentioned this pull request Apr 11, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimurSadykov TimurSadykov TimurSadykov approved these changes

@blakeli0 blakeli0 blakeli0 left review comments

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

Assignees
No one assigned
Labels
size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement GDCH support
5 participants
@poanc @TimurSadykov @blakeli0 @arithmetic1728 @kokoro-team