Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding functional tests for Compute Engine #1105

Merged
merged 5 commits into from Dec 2, 2022
Merged

feat: Adding functional tests for Compute Engine #1105

merged 5 commits into from Dec 2, 2022
+105 −0

Conversation

poanc
Copy link
Contributor

@poanc poanc commented Nov 29, 2022

Adding functional tests for ComputeEngineCredentials.

@poanc poanc added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 29, 2022
@poanc poanc requested a review from a team as a code owner November 29, 2022 02:10
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 29, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 29, 2022
TimurSadykov
TimurSadykov approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit variable rename.

LGTM if kokoro runs )

oauth2_http/javatests/com/google/auth/oauth2/functional/FTComputeEngineCredentialsTest.java Outdated Show resolved Hide resolved
@poanc poanc merged commit 6f32ac3 into googleapis:main Dec 2, 2022
@release-please release-please bot mentioned this pull request Dec 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimurSadykov TimurSadykov TimurSadykov approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@poanc @TimurSadykov @kokoro-team