Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: add code sample and test for getting an access token from an im…" #1299

Merged
merged 2 commits into from Oct 11, 2023
Merged

Revert "feat: add code sample and test for getting an access token from an im…" #1299

merged 2 commits into from Oct 11, 2023

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Oct 5, 2023

Reverts #1289
Tests aren't running for the sample as the CI hasn't been configured for it. These samples will potentially move to "java-docs-samples" repo.

@Sita04 Sita04 requested a review from a team as a code owner October 5, 2023 19:18
@snippet-bot
Copy link

snippet-bot bot commented Oct 5, 2023

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. samples Issues that are directly related to samples. labels Oct 5, 2023
@Sita04 Sita04 requested a review from irataxy October 5, 2023 19:19
@Sita04 Sita04 assigned anguillanneuf and unassigned kweinmeister Oct 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Sita04 Sita04 merged commit 2d867b0 into main Oct 11, 2023
20 checks passed
@Sita04 Sita04 deleted the revert-1289-impersonate branch October 11, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bourgeoisor bourgeoisor bourgeoisor approved these changes

@irataxy irataxy irataxy approved these changes

Assignees

@anguillanneuf anguillanneuf

Labels
samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Sita04 @bourgeoisor @irataxy @anguillanneuf @kweinmeister