Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport the fix to the public key caching for the IdTokenVerifier #929

Closed
TimurSadykov opened this issue Jun 13, 2022 · 2 comments
Closed

Backport the fix to the public key caching for the IdTokenVerifier #929

TimurSadykov opened this issue Jun 13, 2022 · 2 comments
Assignees
@TimurSadykov
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@TimurSadykov
Copy link
Member

Current public key fetch on the IdTokenVerified can cache empty entry for 1 hour if request fails for any reason. We want to backport the fix that keep old entries active during failures: googleapis/google-oauth-java-client#892
@TimurSadykov TimurSadykov self-assigned this Jun 13, 2022
@TimurSadykov TimurSadykov added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 13, 2022
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 18, 2022
@TimurSadykov TimurSadykov added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jul 8, 2022
@TimurSadykov
Copy link
Member Author

Dropped the priority since this library throws errors and users can retry effectively. Fix is in progress, ETA Jul 12

@TimurSadykov TimurSadykov mentioned this issue Aug 9, 2022
Merged
@TimurSadykov
Copy link
Member Author

A fix got checked in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimurSadykov TimurSadykov

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TimurSadykov @yoshi-automation