fix: updates IdTokenVerifier so that it does not cache a failed public key response #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-sunder-s
reviewed
Aug 9, 2022
clundin25
approved these changes
Aug 9, 2022
🤖 I have created a release *beep* *boop* --- ## [1.10.0](v1.9.0...v1.10.0) (2022-08-05) ### Features * workforce identity federation for pluggable auth ([#959](#959)) ([7f2c535](7f2c535)) ### Bug Fixes * updates executable response spec for executable-sourced credentials ([#955](#955)) ([48ff83d](48ff83d)) ### Documentation * **samples:** added auth samples and tests ([#927](#927)) ([32c717f](32c717f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
TimurSadykov
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoiding caching an empty entry in case of public key request failure
avoiding caching a corrupted response of a public key request
Fixes the #929 ☕️