Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change revoke request from get to post #979

Merged
merged 2 commits into from Aug 17, 2022
Merged

fix: change revoke request from get to post #979

merged 2 commits into from Aug 17, 2022

Conversation

sai-sunder-s
Copy link
Contributor

https://oauth2.googleapis.com/revoke does not have a GET endpoint. It has only a POST. So updating the code accordingly.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<782> ☕️

If you write sample code, please follow the samples format.

@sai-sunder-s sai-sunder-s requested a review from a team as a code owner August 12, 2022 22:43
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 12, 2022
TimurSadykov
TimurSadykov approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sai-sunder-s sai-sunder-s merged commit ead58b2 into googleapis:main Aug 17, 2022
@release-please release-please bot mentioned this pull request Aug 17, 2022
Merged
@sai-sunder-s sai-sunder-s mentioned this pull request Aug 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimurSadykov TimurSadykov TimurSadykov approved these changes

@clundin25 clundin25 clundin25 approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sai-sunder-s @TimurSadykov @clundin25